Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): remote readonly recordings access #82

Merged
merged 1 commit into from
Mar 22, 2023
Merged

feat(api): remote readonly recordings access #82

merged 1 commit into from
Mar 22, 2023

Conversation

andrewazores
Copy link
Member

See #78 and #80

This adds a /recordings API endpoint that exposes readonly information about the recordings present in the JVM.

@andrewazores andrewazores mentioned this pull request Mar 21, 2023
Merged
7 tasks
@andrewazores andrewazores added the feat New feature or request label Mar 21, 2023
maxcao13
maxcao13 approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@maxcao13 maxcao13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me!

@andrewazores andrewazores merged commit 31c821e into cryostatio:main Mar 22, 2023
@andrewazores andrewazores deleted the read-recording-state branch March 22, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxcao13 maxcao13 maxcao13 approved these changes

@tthvo tthvo Awaiting requested review from tthvo

Assignees
No one assigned
Labels
feat New feature or request
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @maxcao13