fix(template): should truly close the inputstream

cryostatio · Jun 22, 2023 · 654be7e · 654be7e
1 parent d4ac034
commit 654be7e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java b/src/main/java/io/cryostat/core/agent/LocalProbeTemplateService.java
@@ -91,7 +91,8 @@ public ProbeTemplate addTemplate(InputStream inputStream, String filename)
             throws FileAlreadyExistsException, IOException, SAXException {
         Path path = fs.pathOf(env.getEnv(TEMPLATE_PATH), filename);
         if (fs.exists(path)) {
-            throw new FileAlreadyExistsException(filename);
+            throw new FileAlreadyExistsException(
+                    String.format("Probe template \"%s\" already exists.", filename));
         }
         try (inputStream) {
             ProbeTemplate template = new ProbeTemplate();

diff --git a/src/main/java/io/cryostat/core/agent/ProbeTemplate.java b/src/main/java/io/cryostat/core/agent/ProbeTemplate.java
@@ -107,7 +107,7 @@ public void deserialize(InputStream xmlStream) throws IOException, SAXException
         }
 
         Document document = builder.parse(stream);
-        stream.close();
+        stream.trulyClose();
         NodeList elements;
 
         // parse global configurations