chore(jmc-core): use org.openjdk.jmc.jdp from maven central #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
approved these changes
May 30, 2023
|
Looks good, thanks @aptmac . Could you set up GPG signing on your workstation and GH account? https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification |
aptmac
force-pushed
the
use-jdp-from-maven-central
branch
from
cb600de
to
49fdfc2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #225, in which it'd be nice to remove the embedded jdp classes in cryostat-core in favour of bringing in jdp from maven central.
org.openjdk.jmc.jdp was moved to jmc-core back in 2020, and was a part of the 8.0.0 release. Now that cryostat-core uses jmc8 classes instead of jmc7, it'd make sense to use maven central for jdp now.