Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reports): remove HTML-based generation and transformers #261

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Sep 22, 2023

  • chore(reports): remove HTML-based generation and transformers
  • restructure analysis result for separate fields
  • remove JFR event types

Fixes #209
Fixes #246
Closes cryostatio/cryostat-reports#14

@andrewazores andrewazores added chore Refactor, rename, cleanup, etc. breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere labels Sep 22, 2023
@andrewazores andrewazores marked this pull request as ready for review September 25, 2023 17:35
@andrewazores
Copy link
Member Author

andrewazores commented Sep 25, 2023

This is part of a series of related PRs.

@andrewazores
Copy link
Member Author

@aali309 @mwangggg ping

@andrewazores
Copy link
Member Author

For ease of review:

$ CRYOSTAT_IMAGE=quay.io/andrewazores/cryostat:json-reports REPORTS_IMAGE=quay.io/andrewazores/cryostat-reports:json-reports sh smoketest.sh

Copy link
Member

@mwangggg mwangggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me as well

@andrewazores andrewazores merged commit c1545d9 into cryostatio:main Sep 27, 2023
11 checks passed
@andrewazores andrewazores deleted the rules-analysis-structure branch September 27, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This change (potentially) breaks API compatibility and requires corresponding changes elsewhere chore Refactor, rename, cleanup, etc.
Projects
No open projects
Status: Done
3 participants