-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(reports): remove HTML-based generation and transformers #261
Merged
andrewazores
merged 5 commits into
cryostatio:main
from
andrewazores:rules-analysis-structure
Sep 27, 2023
Merged
chore(reports): remove HTML-based generation and transformers #261
andrewazores
merged 5 commits into
cryostatio:main
from
andrewazores:rules-analysis-structure
Sep 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
added
chore
Refactor, rename, cleanup, etc.
breaking change
This change (potentially) breaks API compatibility and requires corresponding changes elsewhere
labels
Sep 22, 2023
This was referenced Sep 22, 2023
This is part of a series of related PRs.
|
For ease of review: $ CRYOSTAT_IMAGE=quay.io/andrewazores/cryostat:json-reports REPORTS_IMAGE=quay.io/andrewazores/cryostat-reports:json-reports sh smoketest.sh |
7 tasks
mwangggg
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
aali309
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
This change (potentially) breaks API compatibility and requires corresponding changes elsewhere
chore
Refactor, rename, cleanup, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #209
Fixes #246
Closes cryostatio/cryostat-reports#14