-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): restore CI on push workflow #279
Conversation
not sure if I should update |
I was actually about to say the opposite. The published artifact builds with JDK 11 for wider compatibility:
so I think this should either match and build with 11 only, or it should be an 11/17/21 matrix. |
I'll leave it as 11 then |
To run smoketest:
|
2 similar comments
To run smoketest:
|
To run smoketest:
|
To run smoketest:
|
1 similar comment
To run smoketest:
|
I, uh, think that was a little excessive 😅 I suspect this is the problem:
The concurrency group is based on the run ID, but each time the PR is relabelled or a new commit is pushed I think that triggers a new run with a new ID, so many concurrent jobs can be running in the background on the same actual code if we're just relabelling the PR etc. |
/build_test |
Just to test that out ^ https://github.com/cryostatio/cryostat-core/actions/runs/6580357398 |
Nice, it passed - would be even nicer if the status got reported, either as a comment again like we already have elsewhere, or as a status check item |
fixes: #277