Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): restore CI on push workflow #279

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

mwangggg
Copy link
Member

fixes: #277

@mwangggg
Copy link
Member Author

not sure if I should update setup-java version to 21?

@mwangggg mwangggg added ci chore Refactor, rename, cleanup, etc. labels Oct 19, 2023
@andrewazores
Copy link
Member

I was actually about to say the opposite. The published artifact builds with JDK 11 for wider compatibility:

so I think this should either match and build with 11 only, or it should be an 11/17/21 matrix.

@mwangggg
Copy link
Member Author

I'll leave it as 11 then

@github-actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-arm64

To run smoketest:

# amd64          
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-arm64 sh smoketest.sh

2 similar comments
@github-actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-arm64

To run smoketest:

# amd64          
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-arm64 sh smoketest.sh

@github-actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-arm64

To run smoketest:

# amd64          
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-279-bb9044bd32c31e86351dec7feca9f05aaba4d758-linux-arm64 sh smoketest.sh

@github-actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-279-7ef1d805db9e3461c88934c9c130677d907e9bc2-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-279-7ef1d805db9e3461c88934c9c130677d907e9bc2-linux-arm64

To run smoketest:

# amd64          
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-279-7ef1d805db9e3461c88934c9c130677d907e9bc2-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-279-7ef1d805db9e3461c88934c9c130677d907e9bc2-linux-arm64 sh smoketest.sh

1 similar comment
@github-actions
Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-279-7ef1d805db9e3461c88934c9c130677d907e9bc2-linux-amd64
arm64 ghcr.io/cryostatio/cryostat-core:pr-279-7ef1d805db9e3461c88934c9c130677d907e9bc2-linux-arm64

To run smoketest:

# amd64          
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-279-7ef1d805db9e3461c88934c9c130677d907e9bc2-linux-amd64 sh smoketest.sh

# or arm64
CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-279-7ef1d805db9e3461c88934c9c130677d907e9bc2-linux-arm64 sh smoketest.sh

@andrewazores
Copy link
Member

I, uh, think that was a little excessive 😅

I suspect this is the problem:

group: ci-${{ github.run_id }}

The concurrency group is based on the run ID, but each time the PR is relabelled or a new commit is pushed I think that triggers a new run with a new ID, so many concurrent jobs can be running in the background on the same actual code if we're just relabelling the PR etc.

@andrewazores
Copy link
Member

/build_test

@andrewazores
Copy link
Member

@andrewazores
Copy link
Member

Nice, it passed - would be even nicer if the status got reported, either as a comment again like we already have elsewhere, or as a status check item

@andrewazores andrewazores merged commit f21bb9c into cryostatio:main Oct 20, 2023
19 of 20 checks passed
@mwangggg mwangggg deleted the 277-PR-push-workflow branch March 12, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. ci safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Task] CI on push to main
2 participants