Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): downgrade spotbugs #296

Merged
merged 2 commits into from
Nov 14, 2023
Merged

build(deps): downgrade spotbugs #296

merged 2 commits into from
Nov 14, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Nov 14, 2023 •
edited
Loading

See #295 #294 #272

@andrewazores andrewazores requested a review from a team as a code owner November 14, 2023 14:14
@andrewazores andrewazores added dependencies Pull requests that update a dependency file chore Refactor, rename, cleanup, etc. safe-to-test labels Nov 14, 2023
@andrewazores andrewazores changed the title build(deps): downgrade com.github.spotbugs:spotbugs-maven-plugin build(deps): downgrade spotbugs Nov 14, 2023
@andrewazores
Copy link
Member Author

What's happening with the CI here... ? Is it not checking out the PR but main instead? I didn't notice the Spotbugs failures on the PR upgrading the version, and here where I am downgrading the version it is still running the newer failing version. @aali309 @mwangggg

@andrewazores andrewazores merged commit a05ab9f into cryostatio:main Nov 14, 2023
14 of 15 checks passed
@andrewazores andrewazores deleted the backout-spotbugs branch November 14, 2023 14:45
@aali309
Copy link
Contributor

aali309 commented Nov 14, 2023

What's happening with the CI here... ? Is it not checking out the PR but main instead? I didn't notice the Spotbugs failures on the PR upgrading the version, and here where I am downgrading the version it is still running the newer failing version. @aali309 @mwangggg

Was this resolved?

@andrewazores
Copy link
Member Author

No, I just ignored it and merged the Spotbugs downgrade. The CI still appeared to be picking up the newer version from main and failing the PR CI with it.

@andrewazores andrewazores mentioned this pull request Nov 14, 2023
Closed
@mwangggg mwangggg mentioned this pull request Nov 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aptmac aptmac aptmac approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewazores @aali309 @aptmac