Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(cryostat3): build and test against cryostat 3.0 #353

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Feb 22, 2024

Related to #352

Still TODO: the pom.xml build.arch property isn't used for multiarch builds anymore, and the CI build for 3.0 only builds for amd64. This can be updated to use buildah to produce a multiarch build.

@andrewazores andrewazores added ci chore Refactor, rename, cleanup, etc. safe-to-test labels Feb 22, 2024
@andrewazores andrewazores marked this pull request as ready for review February 22, 2024 19:08
@andrewazores
Copy link
Member Author

Sample run:

#353

https://github.com/andrewazores/cryostat-core/actions/runs/8009669029/job/21878906203?pr=3

Failing because there are breaking changes in -core 2.29.0 which none of the dependent projects have been updated for yet.

@andrewazores
Copy link
Member Author

Just to be sure this is working properly, I have opened #354 . After that is merged I will do an upstream -core release, then update Cryostat3 to use that version. After that this PR should be able to build and test Cryostat3.

@andrewazores
Copy link
Member Author

-core 2.29.0 is out and cryostat3 is updated for it. Updated sample runs look good:

https://github.com/andrewazores/cryostat-core/actions/runs/8011523921/job/21885312715?pr=3

andrewazores#3

@andrewazores andrewazores merged commit 6d20a73 into cryostatio:main Feb 22, 2024
13 of 15 checks passed
@andrewazores andrewazores deleted the ci-build-3 branch February 22, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. ci safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants