fix(discovery): plugin registration bugfixes #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @andrewazores! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
github-actions
bot
added
the
needs-triage
|
Hi @andrewazores! Add at least one of the required labels to this PR Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test |
andrewazores
added
fix
and removed
needs-triage
|
/request_review |
|
This PR/issue depends on:
|
|
/build_test |
To run smoketest: |
tthvo
reviewed
Sep 7, 2023
tthvo
reviewed
Sep 7, 2023
tthvo
reviewed
Sep 7, 2023
Looks like this worked as expected here. |
mwangggg
approved these changes
Sep 12, 2023
…egistration/stale prune
… on deregistration/stale prune
andrewazores
force-pushed
the
gh1633
branch
from
8d4fb70
to
e6d8f5e
Compare
andrewazores
added a commit
that referenced
this pull request
Sep 13, 2023
* fix(discovery): delete plugin stored credentials automatically on deregistration/stale prune * delete any stored credentials on plugin callback ping failure * bump minimum event loop pool size * use more specific response code for duplicate matchexpression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: https://github.com/cryostatio/cryostat/issues/1633
See also cryostatio/cryostat-agent#193
Based on #1636
Description of the change:
Improves error handling and cleanup when plugin registrations fail and are associated with stored credentials.
Motivation for the change:
This along with cryostatio/cryostat-agent#193 increases the resiliency of the server/agent registration system so that temporary networking failures or registration conflicts or other bugs are less likely to leave the server and agent both in a state where neither recognizes the other and yet neither is able to clean up and reset the registration status.
How to manually test:
podman killsome agent instances to prevent clean shutdownpodman run(referencesmoketest.shfor exact invocation) to restart some of the killed agent instances to spin them back up