Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(tags): do not tag images as 'latest' #1940

Merged
merged 1 commit into from
Jun 5, 2024
Merged

ci(tags): do not tag images as 'latest' #1940

merged 1 commit into from
Jun 5, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related to cryostatio/cryostat#469

Any CI-built images from this repository should no longer be tagged as latest.

@andrewazores andrewazores added ci chore Refactor, rename, cleanup, etc. safe-to-test labels Jun 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Hi @andrewazores! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@andrewazores andrewazores requested a review from ebaron June 5, 2024 19:24
@andrewazores andrewazores merged commit 62cc0e4 into cryostatio:main Jun 5, 2024
16 of 17 checks passed
@andrewazores andrewazores deleted the ci-latest-tag branch June 5, 2024 20:44
mergify bot pushed a commit that referenced this pull request Jun 5, 2024
@andrewazores @mergify
ci(tags): do not tag images as 'latest' (#1940)
56553ef 
(cherry picked from commit 62cc0e4)

# Conflicts:
#	.github/workflows/push-ci.yml
@mergify mergify bot mentioned this pull request Jun 5, 2024
Merged
7 tasks
andrewazores added a commit that referenced this pull request Jun 5, 2024
@mergify @andrewazores
ci(tags): do not tag images as 'latest' (backport #1940) (#1941)
d57bba8 
* ci(tags): do not tag images as 'latest' (#1940)

(cherry picked from commit 62cc0e4)

# Conflicts:
#	.github/workflows/push-ci.yml

* resolve conflicts

* fixup! resolve conflicts

---------

Co-authored-by: Andrew Azores <aazores@redhat.com>
andrewazores added a commit that referenced this pull request Jun 5, 2024
@andrewazores
fixup! ci(tags): do not tag images as 'latest' (backport #1940) (#1941)
454a686
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron Awaiting requested review from ebaron

Assignees
No one assigned
Labels
backport chore Refactor, rename, cleanup, etc. ci safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@andrewazores