Push notifications #330
Merged
Push notifications #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partially remove ClientWriter as well
andrewazores
force-pushed
the
notification-server
branch
from
5376f5a
to
3968f02
Compare
This was referenced Nov 16, 2020
vic-ma
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lays the foundation for #158 . The WebSocket connection used for the Command Channel is expanded to also serve as the Notification Channel. When the Command Channel is dropped, the Notification Channel will remain and become the only use of the WebSocket client connections. In the backend, callsites consume the Notification API by injecting the
NotificationFactory, building aNotification, and callingsend()on it. This writes theNotificationas JSON on the WebSocket connection for clients to receive and do with as they will.Currently the only
Notifications implemented are in theMessagingServeritself, and provide notifications to clients for when a client is connected/disconnected/dropped (connection refused). Clients receive a notification about themselves being connected as well. This can be tested by runningsmoketest.shand then connecting usingwebsocatand the web-client, or simply two instances ofwebsocat.Some future notifications to implement include async JVM discovery (to complete #158), recording creation/deletion/archival, template upload/delete, SSL certificate upload.