Configure jfr-datasource/grafana-dashboard in itests #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
andrewazores
added a commit
to andrewazores/cryostat
that referenced
this pull request
Jun 23, 2021
* Use pre-configured grafana-dashboard * Update jfr-datasource version * Add properties for skipping unit tests and integration tests * Configure jfr-datasource/grafana-dashboard in itests
andrewazores
added a commit
to andrewazores/cryostat
that referenced
this pull request
Jun 23, 2021
* Use pre-configured grafana-dashboard * Update jfr-datasource version * Add properties for skipping unit tests and integration tests * Configure jfr-datasource/grafana-dashboard in itests
andrewazores
added a commit
to andrewazores/cryostat
that referenced
this pull request
Jun 23, 2021
* Use pre-configured grafana-dashboard * Update jfr-datasource version * Add properties for skipping unit tests and integration tests * Configure jfr-datasource/grafana-dashboard in itests
jan-law
pushed a commit
that referenced
this pull request
Jun 23, 2021
andrewazores
added a commit
to andrewazores/cryostat
that referenced
this pull request
Jun 24, 2021
* Use pre-configured grafana-dashboard * Update jfr-datasource version * Add properties for skipping unit tests and integration tests * Configure jfr-datasource/grafana-dashboard in itests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration to the integration test pod setup to include jfr-datasource and grafana-dashboard, so that the integration test environment more closely resembles a realistic "full" Cryostat deployment. Some existing integration tests have been lightly updated to adjust for this.
Since it's fairly related to this change I have also updated the jfr-datasource and grafana-dashboard versions used in smoketest.sh, and I have also added configuration to the pom.xml to add convenient properties for skipping unit tests only or skipping integration tests only.