Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Backport fixes for hidden unit test failures #534

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

andrewazores
Copy link
Member

Backport of #503 and #512

hareetd and others added 2 commits June 23, 2021 11:16
* Remove null test cases and change incorrect Matcher functionality

* Fix incorrect class mocking which causes tests to pass for the wrong reason

* Maintain consistency between tests by allowing use of the same recording name
3.x  preview releases are not correctly running JUnit 5 parameterized tests in all scenarios
@andrewazores andrewazores merged commit c7e441f into cryostatio:v1 Jun 23, 2021
@andrewazores andrewazores deleted the v1-hidden-unit-test-failures branch June 23, 2021 15:30
aali309 pushed a commit to aali309/cryostat-legacy that referenced this pull request Jul 22, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants