test(report): Add report itests #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-law
commented
Jul 29, 2021
jan-law
commented
Jul 30, 2021
andrewazores
reviewed
Aug 3, 2021
added 11 commits
August 3, 2021 18:05
andrewazores
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #474
Tests the HTTP
200and404scenarios for theTargetReportGetHandlerandReportGetHandler.TargetReportITdownloads the report directly from the JVM whereasReportITalso makes one more call to save the recording to archive before getting the report from the archive.Update: All tests are passing
Summary of test failures:1)TargetReportGetHandlerthrows500instead of404when getting a non-existent recording (should pass after #614 is merged)2) When the Jsoup HTML parser parses the report, it returns a list ofUnexpected Tokenerrors. See review below