Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update list of watched objects #415

Closed
Tracked by #294
ebaron opened this issue Jun 13, 2022 · 0 comments · Fixed by #468
Closed
Tracked by #294

Update list of watched objects #415

ebaron opened this issue Jun 13, 2022 · 0 comments · Fixed by #468

Comments

@ebaron
Copy link
Member

ebaron commented Jun 13, 2022

This list is out of date:

// Watch for changes to secondary resources and requeue the owner Cryostat
resources := []client.Object{&appsv1.Deployment{}, &corev1.Service{}, &corev1.Secret{}, &corev1.PersistentVolumeClaim{}}

Originally posted by @ebaron in #294 (comment)

We should add:

  • ServiceAccount
  • Role
  • RoleBinding
  • Ingress
  • Certificate (can these last two be included if cert-manager is absent from cluster?)
  • Issuer

We should also use the Owns method instead of Watches for these, as suggested by the godocs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant