fix(watches): update object types watched by controller #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebaron
force-pushed
the
update-watched-objects
branch
from
554c0ae
to
d517324
Compare
ebaron
force-pushed
the
update-watched-objects
branch
from
d517324
to
de93778
Compare
tthvo
reviewed
Oct 11, 2022
tthvo
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the kinds of objects that the controller watches to ensure that any change to an owned object triggers a reconcile. The cert-manager APIs pose a slight complication since if the resource types do not exist in the Kubernetes API server, the controller will fail to start.
I modified the OpenShift detection logic to also test for cert-manager. Unfortunately, there's no way yet to dynamically update the list of watched object types (kubernetes-sigs/controller-runtime#1884). This means that if the user installs cert-manager after the controller has started, they will have to redeploy the operator to pick up that change.
I changed the setup from using the
Watchesmethod to the newerOwnswhich is recommended for this purpose.Fixes: #415