fix(finalizer): remove finalizers when objects to delete not found #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebaron
force-pushed
the
remove-finalizer-on-404
branch
from
c735172
to
49f0ec4
Compare
andrewazores
approved these changes
Sep 14, 2021
mergify bot
pushed a commit
that referenced
this pull request
Sep 15, 2021
) (cherry picked from commit 4c813f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #245
To test:
make deploy remove_cert_manager create_cryostat_cr IMG=<test_image>. This results in a Cryostat CR with a finalizer applied to it, but unable to proceed due to cert-manager missing.make destroy_cryostat_cr. Deletion should proceed without hanging.