-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resources): add resource limits/requests for operator deployment #423
Conversation
Tests passed and it seems operator deployment appears stable.
Not sure if we have any other criteria for choosing values for resource limits/requests? I used values as suggested from here. |
I wonder why
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I'd guess that just means there are no requests/limits. We were never setting one explicitly before and the crc cluster probably doesn't define any limits by default, just so that it's quickest and easiest for developers to run whatever they want on crc for development and not need to worry about tinkering with resources first. |
It's showing for me in CRC with your changes applied:
If you're running |
Oh yes thanks a lot @ebaron. Just tried with manual deployment to
Any guidance on why there is such a difference in behavior when using bundle deployment instead (I was using Bundle deployment above)? |
When you run Basically YAML definitions in |
Ahhh thank you! I think I understand it more now! But when I previously tried:
The images got pushed to my Quay registry. And the bundle image appears to be pulled from there. https://quay.io/repository/thvo/cryostat-operator-bundle?tab=tags
But the
I wonder if my steps are correct? Any ideas @ebaron? |
This also means I have to build the image and push it to my own Quay registry right? |
That's right |
Your build looks correct to me. I pulled your bundle image and verified that the CSV within it has the resource limits/requests present. Could you check if |
The CSV shows the expected This bug only affects the |
As a workaround, you can run config:
resources: {} The deployment should be recreated with the resource requests and limits present. |
Ahh so this is the issue! I think I understood it now! Also, deleting the |
Fixes #405
Added resource limits/requests for operator deployment.