Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update OpenShift and cert-manager #435

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

ebaron
Copy link
Member

@ebaron ebaron commented Aug 5, 2022

This PR updates the OpenShift API and cert-manager API to versions that target Kubernetes 1.24. The cert-manager import path changed beginning with 1.8.

Fixes: #434

@ebaron ebaron added the build label Aug 5, 2022
@ebaron ebaron requested a review from tthvo August 5, 2022 20:58
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think we could also change this link.

- [`cert-manager`](https://github.com/jetstack/cert-manager) v1.3.0+ (Recommended)

Also, I wonder we need to update cert-manager version here too?

CERT_MANAGER_VERSION ?= 1.5.3

go.mod Outdated Show resolved Hide resolved
@ebaron
Copy link
Member Author

ebaron commented Aug 8, 2022

Looks great! I think we could also change this link.

- [`cert-manager`](https://github.com/jetstack/cert-manager) v1.3.0+ (Recommended)

Also, I wonder we need to update cert-manager version here too?

CERT_MANAGER_VERSION ?= 1.5.3

I've updated these. I also used cert-manager 1.7.1 instead of the newest, since this is what is currently available with the Red Hat cert-manager operator: https://catalog.redhat.com/software/containers/cert-manager/cert-manager-operator-rhel8/61a60be7bfd4a5234d596292

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!

@ebaron ebaron merged commit 56867fb into cryostatio:main Aug 8, 2022
@ebaron ebaron added the chore Refactor, rename, cleanup, etc. label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build chore Refactor, rename, cleanup, etc.
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update dependencies that rely on Kubernetes
2 participants