Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(makefile): use ignore-not-found flag when deleting resources #453

Merged
merged 1 commit into from
Sep 15, 2022
Merged

fix(makefile): use ignore-not-found flag when deleting resources #453

merged 1 commit into from
Sep 15, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Sep 14, 2022

Related to #430

Specified --ignore-not-found for any $(KUBE_CLIENT) delete calls.

@tthvo tthvo added the fix label Sep 14, 2022
@tthvo tthvo requested a review from ebaron September 14, 2022 19:13
ebaron
ebaron approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for keeping it consistent.

@ebaron ebaron merged commit 78021e0 into cryostatio:main Sep 15, 2022
@tthvo tthvo deleted the update-makefile branch September 19, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
fix
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tthvo @ebaron