Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(security): security contexts are now configurable #457

Merged
merged 6 commits into from
Sep 21, 2022
Merged

feat(security): security contexts are now configurable #457

merged 6 commits into from
Sep 21, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Sep 19, 2022

Fixes #446

Users can now specify security contexts in Cryostat CR to overwrite defaults.

@tthvo tthvo added the feat New feature or request label Sep 19, 2022
@tthvo tthvo requested a review from ebaron September 19, 2022 20:08
@tthvo
Copy link
Member Author

tthvo commented Sep 19, 2022

I added the spec field under Advanced. Any thoughts?

Screenshot from 2022-09-19 14-14-25
Screenshot from 2022-09-19 14-14-47

ebaron
ebaron reviewed Sep 21, 2022
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tthvo, looks good so far! I'm still working through it, but here are a couple suggestions for the documentation.

docs/config.md Outdated Show resolved Hide resolved
ebaron
ebaron reviewed Sep 21, 2022
View reviewed changes
internal/test/resources.go Outdated Show resolved Hide resolved
ebaron
ebaron approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Thanks again @tthvo!

@ebaron ebaron merged commit f114fc0 into cryostatio:main Sep 21, 2022
@tthvo tthvo deleted the security-options branch October 6, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

Assignees
No one assigned
Labels
feat New feature or request
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security Context should be configurable with Cryostat CRD
2 participants
@tthvo @ebaron