Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(samples): update sample app definitions #460

Merged
merged 5 commits into from
Sep 26, 2022
Merged

chore(samples): update sample app definitions #460

merged 5 commits into from
Sep 26, 2022

Conversation

andrewazores
Copy link
Member

Fixes #459

  • remove very outdated sample app 2
  • use updated vertx-fib-demo
  • patch service for port name
  • apply container limits to sample app

@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Sep 26, 2022
@andrewazores andrewazores marked this pull request as ready for review September 26, 2022 15:23
ebaron
ebaron approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

tthvo
tthvo approved these changes Sep 26, 2022
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :D Thanksss

@andrewazores andrewazores merged commit c9b23f9 into cryostatio:main Sep 26, 2022
@andrewazores andrewazores deleted the update-samples branch September 26, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@tthvo tthvo tthvo approved these changes

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc.
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update sample apps
3 participants
@andrewazores @ebaron @tthvo