fix(deploy): recreate deployment if selector changed #472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the Deployment update code to detect when the immutable selector has changed. When this is detected, the operator deletes the deployment and recreates it. With this change it should be possible to upgrade from 2.0 to 2.2, the deployment selectors were changed in 2.1. I built a catalog image to help test this upgrade scenario:
quay.io/ebaron/cryostat-operator-catalog:selector-fix-01
.To test:
component
label:Fixes: #433, #388