feat(discovery): discovery port name/number options for v1betav2 #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build_test |
|
LGTM but let's wait for Elliott since he's more familiar with the beta2 API and webhooks etc. |
|
/build_test |
andrewazores
pushed a commit
that referenced
this pull request
Feb 22, 2024
* feat(discovery): discovery port name/number options for v1betav2 * fix(conversion): add missing conversion to betav1
mwangggg
pushed a commit
to mwangggg/cryostat-operator
that referenced
this pull request
Feb 29, 2024
…ostatio#733) * feat(discovery): discovery port name/number options for v1betav2 * fix(conversion): add missing conversion to betav1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit -S -m "YOUR_COMMIT_MESSAGE"Related to #725
Related to #721
Description of the change:
Added discovery port name/number options to CRD
v1betav2. Also, cryostat3 is going to change its behavior for these port name/number env var (cryostatio/cryostat#238 (comment)). I will save it for another PR after #727Motivation for the change:
Missing equivalent specs in
v1betav2for discovery port name/number option.