Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api): remove minimal option from CR spec #751

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Mar 6, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #728

Description of the change:

  • Removed minimal mode support in v1beta2 API.

Motivation for the change:

See #728

How to manually test:

Set up and rebuild images:

export IMAGE_NAMESPACE=quay.io/<namespace>
export IMAGE_VERSION=3.0.0-remove-minimal
make oci-build bundle bundle-build
podman push quay.io/<namespace>/cryostat-operator:$IMAGE_VERSION
podman push quay.io/<namespace>/cryostat-operator-bundle:$IMAGE_VERSION
make deploy_bundle

With OpenShift:

yq .spec.minimal=true config/samples/operator_v1beta1_cryostat.yaml | oc apply -f -

With k8s (and Nginx Ingress Controller):

Create a CR with the following specs in this https://gist.github.com/tthvo/4be15d6ad0b52c5e1d6ee6f053f12371.

kubectl apply -f <path-to-cr.yaml>

Watch the beta1 CR converted to beta2 without minimal mode and the k8s resources are created correctly as in non-minimal mode.

@tthvo tthvo added chore Refactor, rename, cleanup, etc. safe-to-test labels Mar 6, 2024
@tthvo tthvo marked this pull request as ready for review March 6, 2024 10:43
@tthvo tthvo requested review from a team and ebaron March 6, 2024 10:44
@tthvo tthvo force-pushed the remove-minimal branch 2 times, most recently from 062f1d5 to 9dd5e09 Compare March 8, 2024 23:09
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tthvo, code looks great! Just need to resolve a couple conflicts after #743.

@tthvo
Copy link
Member Author

tthvo commented Mar 18, 2024

Updated and resolved conflicts now :D

@tthvo
Copy link
Member Author

tthvo commented Mar 18, 2024

/build_test

Copy link

/build_test completed successfully ✅.
View Actions Run.

Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tthvo!

@ebaron ebaron merged commit 2619ae0 into cryostatio:cryostat3 Mar 19, 2024
7 checks passed
@tthvo tthvo deleted the remove-minimal branch March 19, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants