Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(resources): cleanup v1beta1 resources #847

Merged
merged 1 commit into from
Jun 5, 2024
Merged

chore(resources): cleanup v1beta1 resources #847

merged 1 commit into from
Jun 5, 2024

Conversation

mwangggg
Copy link
Member

@mwangggg mwangggg commented Jun 5, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #846

@mwangggg mwangggg added the chore Refactor, rename, cleanup, etc. label Jun 5, 2024
@mwangggg mwangggg requested a review from a team as a code owner June 5, 2024 19:05
@mwangggg mwangggg changed the base branch from main to cryostat3 June 5, 2024 19:05
@mergify mergify bot added the safe-to-test label Jun 5, 2024
@mwangggg
Copy link
Member Author

mwangggg commented Jun 5, 2024

/build_test

@mwangggg
Copy link
Member Author

mwangggg commented Jun 5, 2024

/build_test

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

/build_test : At least one test failed ❌.
View Actions Run.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 5, 2024

/build_test completed successfully ✅.
View Actions Run.

ebaron
ebaron approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mwangggg!

@ebaron ebaron merged commit 7025c66 into cryostatio:cryostat3 Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@andrewazores andrewazores Awaiting requested review from andrewazores

Assignees
No one assigned
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
No open projects
3.0.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore] cleanup usage of v1beta1 resources
2 participants
@mwangggg @ebaron