Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build): query scorecard image tags with registry v2 api (backport #915) #916

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 11, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits: git commit -S -m "YOUR_COMMIT_MESSAGE"

Fixes: #914

Description of the change:

Motivation for the change:

See #914. I avoided fetching tags since the tag list can grow rather large with time. This method should basically query in constant time and also skip pulling the image layers.

How to manually test:

Check if a image for specified tag exists:

TAG=3.0.1-20240704162318
curl -ILs -o /dev/null https://quay.io/v2/cryostat/cryostat-operator-scorecard/manifests/$TAG -w "%{http_code}"

Sample run: https://github.com/tthvo/cryostat-operator/actions/runs/9884455121/job/27300862066


This is an automatic backport of pull request #915 done by [Mergify](https://mergify.com).

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
(cherry picked from commit 54ca044)
@ebaron ebaron merged commit 61844db into cryostat-v3.0 Jul 31, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/cryostat-v3.0/pr-915 branch July 31, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants