Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(volume): only set volume server tuning parameters if env vars provided, do not preallocate volumes by default #14

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 8, 2024

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Description of the change:

Only set the volume tuning parameters if the environment variables controlling them are supplied. Otherwise, let Seaweed use its own defaults.

Motivation for the change:

The default configurations with this version of Seaweed already do a good job of utilizing the available space within the DATA_DIR to store files and metadata.

How to manually test:

  1. See chore(storage): remove storage volume parameter overrides cryostat-helm#130

…rovided, do not preallocate volumes by default
@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Apr 8, 2024
@andrewazores andrewazores marked this pull request as ready for review April 10, 2024 14:15
@andrewazores andrewazores requested a review from ebaron April 10, 2024 14:15
@andrewazores andrewazores merged commit b83da17 into cryostatio:main Apr 10, 2024
1 check passed
@andrewazores andrewazores deleted the volume-tuning branch April 10, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants