Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Warning modal for disabling rule should say "disable" instead of "delete" #1042

Closed
tthvo opened this issue May 31, 2023 · 0 comments · Fixed by #1043
Closed

[Bug] Warning modal for disabling rule should say "disable" instead of "delete" #1042

tthvo opened this issue May 31, 2023 · 0 comments · Fixed by #1043
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tthvo
Copy link
Member

tthvo commented May 31, 2023

Current Behavior:

The description is currentlyIf you click Delete, the rule will be disabled., which is incorrect when disabling rules.

Expected Behavior:

The description should be If you click Disable, the rule will be disabled.

Screenshots

Screenshot from 2023-05-31 18-03-27
@tthvo tthvo added bug Something isn't working good first issue Good for newcomers labels May 31, 2023
@tthvo tthvo moved this to Todo in 2.3.1 release May 31, 2023
@tthvo tthvo moved this to Backlog in 2.4.0 release May 31, 2023
@jobayer12 jobayer12 mentioned this issue May 31, 2023
Merged
7 tasks
@andrewazores andrewazores moved this from Todo to In Progress in 2.3.1 release Jun 6, 2023
@aali309 aali309 self-assigned this Jul 14, 2023
@aali309 aali309 removed their assignment Jul 25, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2.3.1 release Aug 2, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in 2.4.0 release Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
No open projects
2.3.1 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
2 participants
@aali309 @tthvo