Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): Warning modal for disabling rule should say "disable" instead of "delete" #1043

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix(modal): Warning modal for disabling rule should say "disable" instead of "delete" #1043

merged 2 commits into from
Aug 2, 2023

Conversation

jobayer12
Copy link
Contributor

@jobayer12 jobayer12 commented May 31, 2023 •
edited by andrewazores
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1042
Depends on #1070

Description of the change:

*[Bug] Warning modal for disabling rule should say "disable" instead of "delete"

@jobayer12 jobayer12 changed the title fix(modal): Warning modal for disabling rule should say "disable" ins… fix(modal): Warning modal for disabling rule should say "disable" instead of "delete" May 31, 2023
@tthvo tthvo requested review from andrewazores and tthvo May 31, 2023 22:56
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1043-b70c5988d163eefa40dc110676d7dbb8c7ffcc45 sh smoketest.sh

tthvo
tthvo approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@tthvo tthvo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jobayer12 for contributing! Looks good to me!

Could you also sign your commit and do a quick rebase?

https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#ssh-commit-signature-verification

@github-actions github-actions bot removed the dependent label Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

This PR/issue depends on:

@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1043-230595c735769007f4aba92ddd8382baf6f379fa sh smoketest.sh

@andrewazores andrewazores merged commit 796d317 into cryostatio:main Aug 2, 2023
mergify bot pushed a commit that referenced this pull request Aug 2, 2023
@jobayer12 @mergify
fix(modal): Warning modal for disabling rule should say "disable" ins…
6282850 
…tead of "delete" (#1043)

(cherry picked from commit 796d317)
@mergify mergify bot mentioned this pull request Aug 2, 2023
Merged
andrewazores pushed a commit that referenced this pull request Aug 2, 2023
@mergify @jobayer12
fix(modal): Warning modal for disabling rule should say "disable" ins…
6b9414b 
…tead of "delete" (#1043) (#1077)

(cherry picked from commit 796d317)

Co-authored-by: Jobayer Ahmed <jobayer6735@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthvo tthvo tthvo approved these changes

@andrewazores andrewazores Awaiting requested review from andrewazores

Assignees
No one assigned
Labels
backport fix safe-to-test
Projects
No open projects
2.3.1 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Warning modal for disabling rule should say "disable" instead of "delete"
3 participants
@jobayer12 @tthvo @andrewazores