Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Target deletion should show deletion warning popup #492

Closed
maxcao13 opened this issue Aug 3, 2022 · 0 comments · Fixed by #534
Closed

[Task] Target deletion should show deletion warning popup #492

maxcao13 opened this issue Aug 3, 2022 · 0 comments · Fixed by #534
Assignees
@tthvo
Labels
feat New feature or request good first issue Good for newcomers

Comments

@maxcao13
Copy link
Member

maxcao13 commented Aug 3, 2022 •
edited
Loading

I think deleting a Target from the TargetSelect dropdown should probably have a deletion warning, similar to the ones for deleting recordings, rules, credentials, etc.
@maxcao13 maxcao13 added the feat New feature or request label Aug 3, 2022
@maxcao13 maxcao13 changed the title [Task] Target deletion should have show deletion warning popup [Task] Target deletion should show deletion warning popup Aug 3, 2022
@maxcao13 maxcao13 added the good first issue Good for newcomers label Aug 5, 2022
@tthvo tthvo moved this to Todo in 2.2.0 Release Sep 19, 2022
@tthvo tthvo self-assigned this Oct 4, 2022
@tthvo tthvo mentioned this issue Oct 4, 2022
Merged
Repository owner moved this from Todo to Done in 2.2.0 Release Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tthvo tthvo

Labels
feat New feature or request good first issue Good for newcomers
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(target): show warning prompt when deleting custom targets tthvo/cryostat-web
2 participants
@tthvo @maxcao13