Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(target): show warning prompt when deleting custom targets #534

Merged
merged 1 commit into from
Oct 4, 2022
Merged

feat(target): show warning prompt when deleting custom targets #534

merged 1 commit into from
Oct 4, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Oct 4, 2022

Fixes #492

Deleting a custom target now shows a deletion modal if enabled.

@tthvo tthvo added the feat New feature or request label Oct 4, 2022
@tthvo tthvo requested review from andrewazores and maxcao13 October 4, 2022 09:06
@tthvo tthvo marked this pull request as ready for review October 4, 2022 09:06
@andrewazores andrewazores merged commit 56207a4 into cryostatio:main Oct 4, 2022
@tthvo tthvo deleted the target-warning-modal branch October 4, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@maxcao13 maxcao13 Awaiting requested review from maxcao13

Assignees
No one assigned
Labels
feat New feature or request
Projects
No open projects
2.2.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Target deletion should show deletion warning popup
2 participants
@tthvo @andrewazores