Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Unauthorized users should not see settings that requires authentication #981

Closed
tthvo opened this issue Apr 25, 2023 · 0 comments · Fixed by #982
Closed

[Bug] Unauthorized users should not see settings that requires authentication #981

tthvo opened this issue Apr 25, 2023 · 0 comments · Fixed by #982
Assignees
@tthvo
Labels
bug Something isn't working

Comments

@tthvo
Copy link
Member

tthvo commented Apr 25, 2023

Current Behavior:

All settings are displayed. Settings that requires authentication are displayed with a not-very-helpful message.

Expected Behavior:

Settings (i.e. AA Recording) that requires login should not be displayed to logged-out users.

Screenshots

Screenshot from 2023-04-24 23-53-38
@tthvo tthvo added the bug Something isn't working label Apr 25, 2023
@tthvo tthvo moved this to Todo in 2.4.0 release Apr 25, 2023
@tthvo tthvo moved this to In Progress in 2.3.0 release Apr 25, 2023
@tthvo tthvo self-assigned this Apr 25, 2023
@tthvo tthvo mentioned this issue Apr 25, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in 2.4.0 release Apr 25, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in 2.3.0 release Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tthvo tthvo

Labels
bug Something isn't working
Projects
No open projects
2.3.0 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(settings): hide settings that requires auth for logged-out user tthvo/cryostat-web
1 participant
@tthvo