Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): hide settings that requires auth for logged-out user #982

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix(settings): hide settings that requires auth for logged-out user #982

merged 1 commit into from
Apr 25, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Apr 25, 2023 •
edited
Loading

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #981

Description of the change:

Annotate each setting (requires auth) with authenticated field. These settings are hidden when the user is logged out.

When the user logs in, the settings are shown as usual.

Motivation for the change:

See #981

Screenshots

Before After
Screenshot from 2023-04-24 23-53-38 Screenshot from 2023-04-25 01-25-06

@tthvo tthvo added chore Refactor, rename, cleanup, etc. fix backport labels Apr 25, 2023
@tthvo tthvo requested review from andrewazores and maxcao13 April 25, 2023 05:25
@mergify mergify bot added the safe-to-test label Apr 25, 2023
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-982-9029c550c71c194ed5d449334d1e2b8d3ac0eff5 sh smoketest.sh

andrewazores
andrewazores previously approved these changes Apr 25, 2023
View reviewed changes
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-982-afaaf4652fdcd7322a2cc710b1f934bef238b987 sh smoketest.sh

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-982-feafad6b92b0f9f1754aaee98369ff382080eafd sh smoketest.sh

@andrewazores andrewazores merged commit 02266cb into cryostatio:main Apr 25, 2023
mergify bot pushed a commit that referenced this pull request Apr 25, 2023
@mergify
fix(settings): hide settings that requires auth for logged-out user (#…
1924134 
…982)

(cherry picked from commit 02266cb)
@mergify mergify bot mentioned this pull request Apr 25, 2023
Merged
andrewazores pushed a commit that referenced this pull request Apr 25, 2023
@mergify
fix(settings): hide settings that requires auth for logged-out user (#…
05f08b9 
…982) (#985)

(cherry picked from commit 02266cb)

Co-authored-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo deleted the unauth-settings branch April 25, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

@maxcao13 maxcao13 Awaiting requested review from maxcao13

Assignees
No one assigned
Labels
backport chore Refactor, rename, cleanup, etc. fix safe-to-test
Projects
No open projects
2.3.0 release
Status: Done
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Unauthorized users should not see settings that requires authentication
2 participants
@tthvo @andrewazores