fix(topology): catalog btn tooltip should not show if not needed #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test image available: |
maxcao13
reviewed
May 2, 2023
tthvo
force-pushed
the
topology-catalog-btn
branch
from
18e42f9 to
84db0bf
Compare
|
Test image available: |
andrewazores
force-pushed
the
topology-catalog-btn
branch
from
84db0bf to
de48dc7
Compare
Signed-off-by: Thuan Vo <thvo@redhat.com>
tthvo
force-pushed
the
topology-catalog-btn
branch
from
de48dc7 to
8aa59b9
Compare
|
Opps didnt see the previous rebase. No changes applied tho :)) |
|
Test image available: |
andrewazores
approved these changes
May 2, 2023
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2023
Signed-off-by: Thuan Vo <thvo@redhat.com> (cherry picked from commit 96ec510)
andrewazores
pushed a commit
that referenced
this pull request
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffRelated to #891
Related to #1008 (Thanks Max for figuring out the root issue of element focus).
Description of the change:
Mount tooltip closer to the catalog button (modal will clip this tooltip -> close tooltip). Also, unfocus the catalog button -> do not persist tooltip.
Also, fix a css issue where the rules is not applied to the catalog button causing it to have padding.
Motivation for the change:
Catalog button is showing the tooltip over the modal and persist the tooltip after closing modal. We should avoid this.