chore(eslint): apply eslint fixes and remove unused codes

[tthvo]

Welcome to Cryostat! 👋

Before contributing, make sure you have:

• Read the contributing guidelines
• Linked a relevant issue which this PR resolves
• Linked any other relevant issues, PR's, or documentation, if any
• Resolved all conflicts, if any
• Rebased your branch PR on top of the latest upstream main branch
• Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
• Signed the last commit: git commit --amend --signoff

---

Related to #941

Description of the change:

Chores

• Remove unused codes.
• Apply eslint fixes.
• Use FC alias for FunctionComponent (perhaps code base can be a little bit smaller?).

Fixes

• Fixed infinite effect loop error by removing effect that open the problem section.
  • How to reproduce: launch cryostat only with run.sh, observe the problem notification, and the browser console will show error with title Warning: Maximum update depth exceeded.
  • Fix by remove buggy effect and open the problem by default. This fix also allow users to close the problem notification section if needed (previously not possible).

Motivation for the change:

Regular "house-keeping" for codebase.

[github-actions]

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1044-e8f746587e38972e1ec54b6bc617f157a42b3fa9 sh smoketest.sh

[github-actions]

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1044-9be65cb329c099223b6b6f124184ae3835dbda07 sh smoketest.sh

[github-actions]

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1044-107717d6c4e7dde0fe91ebbcc10f9a6668f6cc02 sh smoketest.sh

[github-actions]

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1044-bb5a721d9a3ba4f0661263b4e11c4f7cae190cea sh smoketest.sh

[tthvo]

Seems like if the user chooses minimal deployment, the infinite effect loop error will cause the web-client to be significantly slow. Should be backport this (maybe split the fix into another PR?)?

[andrewazores]

How to reproduce: launch cryostat only with run.sh, observe the problem notification, and the browser console will show error with title Warning: Maximum update depth exceeded.

I wasn't able to reproduce this (backend commit: 332fcbee8b7469935b88f1934dae917f24a3d5c5), I just see a warning notification and no error in the console.

[tthvo]

I wasn't able to reproduce this (backend commit: 332fcbee8b7469935b88f1934dae917f24a3d5c5), I just see a warning notification and no error in the console.

Opps I left out an important step: you need to launch a dev server for front-end to see react warning. Production asset won't show it.

[andrewazores]

I tried:

$ CRYOSTAT_DISABLE_SSL=true CRYOSTAT_CORS_ORIGIN=http://localhost:9000 sh run.sh

in one terminal, and:

$ yarn start:dev

and this seems to reproduce what you're describing. If I click the notification bell to expand the drawer then I get the console errors and cannot collapse the Problem notification section.

[tthvo]

Okayy! Then this PR fixed it right?

[andrewazores]

With this PR branch checked out, repeating the steps above seems to fix it - I can open and close the notification drawer as well as the Problems section, and there is no console error.

[github-actions]

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1044-156b6a4670d30d25cfe34dffa54fee899a46f9a2 sh smoketest.sh