fix(topology): warning resolver should include adding ssl certs #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tthvo
force-pushed
the
topology-warning-actions
branch
from
cf6602c to
8950a8f
Compare
|
Test image available: |
|
Test image available: |
andrewazores
reviewed
Jun 6, 2023
andrewazores
reviewed
Jun 6, 2023
andrewazores
approved these changes
Jun 6, 2023
andrewazores
force-pushed
the
topology-warning-actions
branch
from
deb67ef to
c57f167
Compare
|
Test image available: |
added 3 commits
June 6, 2023 15:11
Signed-off-by: Thuan Vo <thvo@redhat.com>
andrewazores
force-pushed
the
topology-warning-actions
branch
from
c57f167 to
14397a2
Compare
|
Test image available: |
mergify bot
pushed a commit
that referenced
this pull request
Jun 6, 2023
* fix(topology): warning resolver should include adding ssl certs Signed-off-by: Thuan Vo <thvo@redhat.com> * feat(topology): add warning icon next to JVM ID if empty * fix(topology): fix wordings --------- Signed-off-by: Thuan Vo <thvo@redhat.com> (cherry picked from commit 0dd044c)
andrewazores
pushed a commit
that referenced
this pull request
Jun 6, 2023
… (#1052) * fix(topology): warning resolver should include adding ssl certs Signed-off-by: Thuan Vo <thvo@redhat.com> * feat(topology): add warning icon next to JVM ID if empty * fix(topology): fix wordings --------- Signed-off-by: Thuan Vo <thvo@redhat.com> (cherry picked from commit 0dd044c) Co-authored-by: Thuan Vo <thvo@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: #1033
Description of the change:
Add an option to add certificates when JVM ID cannot be computed. Also, a small warning icon next to JVM ID if empty.
Motivation for the change:
See #1033
Screenshots