Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): preview ci should target all under src #1054

Merged
merged 1 commit into from
Jun 8, 2023
Merged

fix(ci): preview ci should target all under src #1054

merged 1 commit into from
Jun 8, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Jun 8, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Related to #1046

Description of the change:

Update path matching to include all under src.

Motivation for the change:

Preview CI should target all under src because there are also i18next and mirage codes.

fix(ci): preview ci should target all under src
7954002 
Signed-off-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo requested a review from andrewazores June 8, 2023 18:14
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1054-795400217b4bda3449d7c2097869b6a909457d05 sh smoketest.sh

@andrewazores andrewazores merged commit db0d4cf into cryostatio:main Jun 8, 2023
@tthvo tthvo deleted the preview-ci branch June 27, 2023 08:51
mergify bot pushed a commit that referenced this pull request Aug 31, 2023
@mergify
fix(ci): preview ci should target all under src (#1054)
d494cfa 
Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit db0d4cf)

# Conflicts:
#	.github/workflows/ci-preview.yml
@mergify mergify bot mentioned this pull request Aug 31, 2023
Merged
andrewazores pushed a commit that referenced this pull request Aug 31, 2023
@mergify
fix(ci): preview ci should target all under src (#1054) (#1101)
92d583c 
Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit db0d4cf)

# Conflicts:
#	.github/workflows/ci-preview.yml

Co-authored-by: Thuan Vo <thvo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewazores andrewazores andrewazores approved these changes

Assignees
No one assigned
Labels
backport ci fix safe-to-test
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tthvo @andrewazores