-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(selenium): add selenium web-driver e2e integration test scaffolding #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Cao <macao@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
github-actions
bot
added
the
needs-triage
Needs thorough attention from code reviewers
label
Jun 20, 2023
maxcao13
changed the title
test(selenium) add selenium web-driver e2e integration test scaffolding
test(selenium): add selenium web-driver e2e integration test scaffolding
Jun 20, 2023
Signed-off-by: Max Cao <macao@redhat.com>
… ci with itest Signed-off-by: Max Cao <macao@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
maxcao13
force-pushed
the
selenium
branch
2 times, most recently
from
June 21, 2023 00:37
2e1f475
to
21a1689
Compare
Test image available:
|
Test image available:
|
Test image available:
|
Signed-off-by: Max Cao <macao@redhat.com>
Test image available:
|
Signed-off-by: Max Cao <macao@redhat.com>
Test image available:
|
Test image available:
|
Signed-off-by: Max Cao <macao@redhat.com>
Test image available:
|
andrewazores
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
git commit --amend --signoff
Fixes: #1038
Fixes: #1031
Description of the change:
The change adds the selenium web-driver integration testing framework to -web. Also adds GitHub CI integration tests.
Requires a web driver for a preferred browser to be added to PATH. I use firefox and geckodriver.
As of now, only
Dashboard
itests exist.yarn itest
waits on the mirage preview dev server on 9091 indefnitely using thewait-on
yarn package. When it get's a response, it runs the Selenium web driver tests on a detected browser.yarn itest:preview
starts a preview mirage server on 9091, and then runs the itests when the server is ready. After the itests finish, the server goes down as well.Other changes
npm-run-all
with the much more powerfulconcurrently
yarn package. Also addswait-on
.actions/setup-java/node
andactions/checkout
to v3 in CI. Also adds dependency caching of both Maven and yarn between CI runs.How to manually test:
See above.