Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(selenium): add selenium web-driver e2e integration test scaffolding #1056

Merged
merged 10 commits into from
Jun 23, 2023

Conversation

maxcao13
Copy link
Member

@maxcao13 maxcao13 commented Jun 20, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed the last commit: git commit --amend --signoff

Fixes: #1038
Fixes: #1031

Description of the change:

The change adds the selenium web-driver integration testing framework to -web. Also adds GitHub CI integration tests.

Requires a web driver for a preferred browser to be added to PATH. I use firefox and geckodriver.

As of now, only Dashboard itests exist.

yarn itest waits on the mirage preview dev server on 9091 indefnitely using the wait-on yarn package. When it get's a response, it runs the Selenium web driver tests on a detected browser.
yarn itest:preview starts a preview mirage server on 9091, and then runs the itests when the server is ready. After the itests finish, the server goes down as well.

Other changes

  • Replaces npm-run-all with the much more powerful concurrently yarn package. Also adds wait-on.
  • Updates both actions/setup-java/node and actions/checkout to v3 in CI. Also adds dependency caching of both Maven and yarn between CI runs.

How to manually test:

See above.

maxcao13 added 2 commits June 20, 2023 13:20
Signed-off-by: Max Cao <macao@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
@maxcao13 maxcao13 added chore Refactor, rename, cleanup, etc. test labels Jun 20, 2023
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Jun 20, 2023
@mergify mergify bot added the safe-to-test label Jun 20, 2023
@maxcao13 maxcao13 changed the title test(selenium) add selenium web-driver e2e integration test scaffolding test(selenium): add selenium web-driver e2e integration test scaffolding Jun 20, 2023
@maxcao13 maxcao13 removed the needs-triage Needs thorough attention from code reviewers label Jun 20, 2023
maxcao13 added 3 commits June 20, 2023 13:52
Signed-off-by: Max Cao <macao@redhat.com>
… ci with itest

Signed-off-by: Max Cao <macao@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
@maxcao13 maxcao13 force-pushed the selenium branch 2 times, most recently from 2e1f475 to 21a1689 Compare June 21, 2023 00:37
@cryostatio cryostatio deleted a comment from github-actions bot Jun 21, 2023
@cryostatio cryostatio deleted a comment from github-actions bot Jun 21, 2023
@cryostatio cryostatio deleted a comment from github-actions bot Jun 21, 2023
@cryostatio cryostatio deleted a comment from github-actions bot Jun 21, 2023
@cryostatio cryostatio deleted a comment from github-actions bot Jun 21, 2023
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1056-21a16899f9582f7d19b75c82f1916d73260e7152 sh smoketest.sh

Signed-off-by: Max Cao <macao@redhat.com>
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1056-42587e8c291aa83eac30d8b53a85f5d6756396c9 sh smoketest.sh

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1056-060362596b199e423bb3d4d564d739b5bc12a6a8 sh smoketest.sh

Signed-off-by: Max Cao <macao@redhat.com>
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1056-5ebcd635c51d5a1898b28352276fbbdbe932679d sh smoketest.sh

Signed-off-by: Max Cao <macao@redhat.com>
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1056-ddb3f2874898a86c183bdb6193d1974621abaf8c sh smoketest.sh

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1056-0d857961b781e5c7dcd9ff738c8dc52358f7f887 sh smoketest.sh

@maxcao13 maxcao13 marked this pull request as ready for review June 21, 2023 08:15
@maxcao13 maxcao13 requested a review from tthvo June 21, 2023 08:55
Signed-off-by: Max Cao <macao@redhat.com>
@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1056-67d7177fac87114be868a9fab017a0df0ac25e81 sh smoketest.sh

@andrewazores andrewazores merged commit a346899 into cryostatio:main Jun 23, 2023
@maxcao13 maxcao13 deleted the selenium branch June 27, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test test
Projects
No open projects
Status: Done
Status: Done
2 participants