chore(itests): add more integration tests and fix CI integration #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-triage
|
Test image available: |
maxcao13
force-pushed
the
integration-tests
branch
from
3679223 to
b2dd212
Compare
|
Test image available: |
maxcao13
force-pushed
the
integration-tests
branch
from
b2dd212 to
e691756
Compare
|
PR pretty much in done state except for any review comments. I hope some one can solve these errors if there are any, but if they are small I can probably resolve them myself. :) |
|
Test image available: |
Signed-off-by: Thuan Vo <thvo@redhat.com>
Signed-off-by: Max Cao <macao@redhat.com>
maxcao13
force-pushed
the
integration-tests
branch
from
6ab8d86 to
3782ea2
Compare
andrewazores
approved these changes
Aug 24, 2023
|
Test image available: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: #1063
Rebased on: #1092
Description of the change:
Fixes CI integration. The flakey tests were due to the browser not loading the correct page fast enough and the web driver erroring out since it couldn't find some elements. I just added a time out to solve this. Also adds a Recording Workflow test suite.
Motivation for the change:
See #1063. There should also be more integration tests so that we can be fully sure of our application.
How to manually test:
yarn itest:preview