feat(match-expression): match expression should be evaluated on backend #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test image available: |
added 2 commits
July 27, 2023 16:12
Signed-off-by: Thuan Vo <thvo@redhat.com>
|
Test image available: |
|
Remaining tasks:
|
|
This PR/issue depends on:
|
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Test image available: |
|
Ready for review now! There are a lot more changes than expected but I tried my best to minimize the number of API requests to One fix that might raise questions is in the stored credential table. When a target appears or disappears, I opted to just refresh the entire table (1 API request) instead of each match expression checking themselves (a lot API requests and React reducer is not fit for async handling). |
|
Test image available: |
andrewazores
reviewed
Aug 1, 2023
andrewazores
reviewed
Aug 1, 2023
andrewazores
reviewed
Aug 1, 2023
|
Test image available: |
|
Test image available: |
|
Test image available: |
andrewazores
reviewed
Aug 1, 2023
|
Test image available: |
andrewazores
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]git commit --amend --signoffFixes: #1067
Depends on https://github.com/cryostatio/cryostat/issues/1601
Description of the change:
Update front-end handler for async checks when evaluating match expression (i.e. done on server via endpoint
/api/beta/matchExpression)Motivation for the change:
See #1067