New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(itest): add supplemental integration testing documentation #1109

Merged

andrewazores merged 8 commits into cryostatio:main from maxcao13:docs

Sep 28, 2023

Member

maxcao13 commented Sep 13, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

Read the contributing guidelines
Linked a relevant issue which this PR resolves
Linked any other relevant issues, PR's, or documentation, if any
Resolved all conflicts, if any
Rebased your branch PR on top of the latest upstream main branch
Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Related #1038

Description of the change:

This change allows contributors to get a better understanding of the integration testing framework.

Member Author

maxcao13 commented Sep 13, 2023

/request_review

github-actions bot added the needs-triage label

maxcao13 added the docs label

Member Author

maxcao13 commented Sep 13, 2023

Oh yeah, we can't do that here, haha

maxcao13 requested review from tthvo and a team

September 13, 2023 20:29

maxcao13 removed the needs-triage label

tthvo requested a review from aali309

September 13, 2023 21:07

tthvo reviewed

View reviewed changes

TESTING.md Show resolved Hide resolved

tthvo reviewed

View reviewed changes

TESTING.md Outdated Show resolved Hide resolved

tthvo reviewed

View reviewed changes

TESTING.md Outdated Show resolved Hide resolved

tthvo reviewed

View reviewed changes

TESTING.md Outdated Show resolved Hide resolved

tthvo reviewed

View reviewed changes

TESTING.md Outdated Show resolved Hide resolved

tthvo reviewed

View reviewed changes

Member

tthvo left a comment

Just some suggestions and questions. Thanks for doing this!

Member Author

maxcao13 commented Sep 14, 2023

Looks good: https://github.com/cryostatio/cryostat-web/actions/runs/6190952199/job/16808255886?pr=1109#step:6:1

tthvo reviewed

View reviewed changes

.github/workflows/ci.yaml Outdated Show resolved Hide resolved

tthvo reviewed

View reviewed changes

TESTING.md Outdated Show resolved Hide resolved

maxcao13 and others added 7 commits

September 27, 2023 15:36


          itest docs

a40f6c5


          Update TESTING.md

35646c5

Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Max Cao <maxy.cao@gmail.com>


          Update TESTING.md

966a05b

Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Max Cao <maxy.cao@gmail.com>


          Update TESTING.md

0c488fd

Co-authored-by: Thuan Vo <thuan.votann@gmail.com>
Signed-off-by: Max Cao <maxy.cao@gmail.com>

fix

d7ad6e7


          version geckodriver

c8e97b6


          changes

fe82eb8

maxcao13 force-pushed the docs branch from 87ff831 to fe82eb8 Compare

September 27, 2023 22:36

tthvo reviewed

View reviewed changes

Member

tthvo left a comment

Thanks! Just one more comment!

TESTING.md Show resolved Hide resolved


          remote dup

df43a54

tthvo approved these changes

View reviewed changes

Member

tthvo left a comment

Lokks good! Thanks @maxcao13!

andrewazores approved these changes

View reviewed changes

andrewazores merged commit 14378bd into cryostatio:main

18 checks passed

maxcao13 deleted the docs branch

November 2, 2023 19:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs