Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump @typescript-eslint deps to 6.7.3 #1125

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Oct 2, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #890

Description of the change:

Bump @typescript-eslint/parser to match that of @typescript-eslint/eslint-plugin. I think these packages are meant to be upgraded together. Dependabot might be missing upgrades for the parser.

I took this chance to bump both of them to 6.7.3.

Motivation for the change:

[user@host]$ yarn explain peer-requirements pd46c8
➤ YN0000: cryostat-web@workspace:. provides @typescript-eslint/parser@npm:5.53.0 [af275] with version 5.53.0, which doesn't satisfy the following requirements:

➤ YN0000: @typescript-eslint/eslint-plugin@npm:6.6.0 [af275] → ^6.0.0 || ^6.0.0-alpha ✘

@tthvo tthvo requested a review from aali309 October 2, 2023 04:50
@tthvo tthvo added the dependencies Pull requests that update a dependency file label Oct 2, 2023
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Oct 2, 2023
@tthvo tthvo added safe-to-test chore Refactor, rename, cleanup, etc. and removed needs-triage Needs thorough attention from code reviewers labels Oct 2, 2023
@tthvo tthvo changed the title build(deps): bump @typescript-eslint/parser 5.53.0 to 6.7.3 build(deps): bump @typescript-eslint deps to 6.7.3 Oct 2, 2023
@tthvo tthvo force-pushed the deps-eslint-parser branch from 1222e31 to 811b5ec Compare October 2, 2023 05:01
@andrewazores
Copy link
Member

/build_test

@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1125-811b5ec5874b2fab40d003b5107102185a1c87d1 sh smoketest.sh

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
@tthvo tthvo force-pushed the deps-eslint-parser branch from 811b5ec to b631ef6 Compare October 2, 2023 16:49
@andrewazores andrewazores merged commit 86a8094 into cryostatio:main Oct 2, 2023
18 checks passed
@tthvo tthvo deleted the deps-eslint-parser branch October 11, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants