Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove unused enzyme deps and fix deps incompatibility #1141

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Oct 20, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #1110
Related to #726

Description of the change:

  • Remove unused enzyme-related dependencies.
  • Explicitly requests react-test-renderer package (v17.0.2). Downgrade @types/react-test-renderer to match.
  • Move runtime deps to their correct sections (i.e. dependencies).
  • Upgrade eslint-plugin-unused-imports to 3.0.0 to match dep requirements. @patternfly/react-topology is still conflicting but must wait till upgrade to PF5.

Motivation for the change:

Preparing for React 18 upgrades. Just splitting #726 into smaller issues/tasks for easy tracking.

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
@tthvo tthvo added dependencies Pull requests that update a dependency file chore Refactor, rename, cleanup, etc. safe-to-test labels Oct 20, 2023
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Oct 20, 2023
@tthvo tthvo requested a review from a team October 20, 2023 06:50
@tthvo tthvo removed the needs-triage Needs thorough attention from code reviewers label Oct 20, 2023
@tthvo
Copy link
Member Author

tthvo commented Oct 20, 2023

/build_test

@github-actions
Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1141-b40427f9f585b70b4da469dde3fc3b3c3533b2cd sh smoketest.sh

@tthvo tthvo changed the title chore(deps): remove unused imports and fix deps incompatibility chore(deps): remove unused enzyme deps and fix deps incompatibility Oct 20, 2023
@andrewazores andrewazores merged commit 9ec90e1 into cryostatio:main Oct 20, 2023
35 of 36 checks passed
@tthvo tthvo deleted the clean-deps branch October 20, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. dependencies Pull requests that update a dependency file safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants