Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): should commit and push changes to src/main/webui #1158

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Nov 7, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Fixes: cryostatio/cryostat#125

Description of the change:

This change adds allows a match expression example to be copied to the clipboard...

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

@aali309
Copy link
Contributor Author

aali309 commented Nov 7, 2023

@andrewazores, does this make sense?

@andrewazores
Copy link
Member

That looks about right. I'll read it a little closer tomorrow, but I think we can probably just merge it and see if it works.

@andrewazores andrewazores merged commit 4b65581 into cryostatio:main Nov 9, 2023
19 checks passed
@aali309 aali309 deleted the pushChangesToWebui branch November 9, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] cryostat-web should commit and push changes to src/main/webui
2 participants