Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(templates): remove auth token download flow #1215

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat#290
Depends on cryostatio/cryostat#290

Description of the change:

Removes the old API v2.1 auth token download flow in the middle of the event template download action. In 3.0 the client can simply request the file.

Motivation for the change:

This enables the "Events -> Event Templates -> SomeTemplate -> Download" feature to work again with 3.0.

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

Copy link

This PR/issue depends on:

@mergify mergify bot added the safe-to-test label Feb 15, 2024
@andrewazores andrewazores changed the title chore(templates): remote auth token download flow chore(templates): remove auth token download flow Feb 15, 2024
@andrewazores andrewazores added the chore Refactor, rename, cleanup, etc. label Feb 15, 2024
@andrewazores andrewazores marked this pull request as ready for review February 16, 2024 14:14
@andrewazores
Copy link
Member Author

/build_test

Copy link

Test image available:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-web:pr-1215-c5b864082901c3600dea8e4b95182d2f2e050ee3 bash smoketest.bash # then open http://localhost:8080

Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@andrewazores andrewazores deleted the template-download branch February 20, 2024 21:32
@andrewazores andrewazores restored the template-download branch February 21, 2024 19:40
@andrewazores
Copy link
Member Author

Accidentally deleted branch before merging...

@andrewazores andrewazores reopened this Feb 21, 2024
@andrewazores andrewazores merged commit 21b16c3 into cryostatio:main Feb 21, 2024
17 of 18 checks passed
@andrewazores andrewazores deleted the template-download branch February 21, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. dependent safe-to-test
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants