Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(certs): replace cert upload flow with cert listing #1240

Merged
merged 3 commits into from
Apr 24, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Apr 16, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat#306
Depends on cryostatio/cryostat#330

Description of the change:

Removes the JMX SSL cert upload modal, rewords some text associated with it, and adds a list of additional loaded certificate files to the Security card so that users can verify if the certificates required for their applications were properly supplied to the Cryostat server and if it should have loaded them to its truststore.


Without vertx-fib-demo.cer loaded:

image

image

With vertx-fib-demo.cer loaded:

image


Motivation for the change:

See #306

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh... -Ot
  2. The vertx-fib-demo.cer is here: https://github.com/andrewazores/vertx-fib-demo/blob/master/src/main/extras/app/resources/vertx-fib-demo.cer
  3. Try with and without that certificate placed within the cryostat3/truststore project directory. smoketest.bash creates a volume with that directory's contents and this becomes the additional truststore for the application within the smoketest.

@andrewazores andrewazores added feat New feature or request safe-to-test labels Apr 16, 2024
@andrewazores andrewazores requested a review from ebaron April 16, 2024 14:25
Copy link

@andrewazores andrewazores force-pushed the jmx-tls-list branch 3 times, most recently from 69a0f12 to 82b9c6b Compare April 23, 2024 19:06
@andrewazores andrewazores merged commit 35303e7 into cryostatio:main Apr 24, 2024
18 checks passed
@andrewazores andrewazores deleted the jmx-tls-list branch April 24, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants