Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): mirage demo fixups for 3.0 #1257

Merged
merged 2 commits into from
May 9, 2024

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented May 9, 2024

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostatio.github.io#176

Description of the change:

  • fixes one small potential bug in how the client requests report generation - the reportUrl will be prefixed by the server's authority if it is not already. This ensures that the client cannot be fooled into making a request to another server than the one it is hosted on. This also fixes a bug in the Mirage report generation
  • fixes up a few small bugs and missing pieces in Mirage for the live demo

Motivation for the change:

Preparing the live demo for 3.0.

How to manually test:

  1. yarn start:dev:preview
  2. Most things vaguely work. You should be able to mostly click around the UI and not get any seriously broken features. Things that specifically don't work: editing recording labels, Archives > All Targets, and other GraphQL-powered features. Automated Rules can be created but don't actually do anything. Match Expressions, in automated rules and in stored credentials, always evaluate to true. But, you should be able to view Topology, Recordings, Events, and even create fake recordings on targets, view fake analysis reports on those recordings, stop/archive/delete recordings, etc.

@mergify mergify bot added the safe-to-test label May 9, 2024
@andrewazores andrewazores marked this pull request as ready for review May 9, 2024 15:49
@andrewazores andrewazores requested review from aali309 and mwangggg May 9, 2024 15:50
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@andrewazores andrewazores merged commit 1c404d7 into cryostatio:main May 9, 2024
25 of 29 checks passed
@andrewazores andrewazores deleted the demo3 branch May 9, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants