Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eventtemplates): support preset event template type #1497

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

andrewazores
Copy link
Member

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to cryostatio/cryostat#548
Depends on cryostatio/cryostat#733

Description of the change:

See cryostatio/cryostat#733

Motivation for the change:

This change is helpful because users may want to copy the example for easier use...

How to manually test:

  1. Run CRYOSTAT_IMAGE=quay.io... sh smoketest.sh...
  2. ...

Copy link

github-actions bot commented Dec 4, 2024

@mergify mergify bot added the safe-to-test label Dec 4, 2024
@andrewazores andrewazores added the feat New feature or request label Dec 4, 2024
@andrewazores
Copy link
Member Author

Not sure what's up with the snapshot test failure. It passes fine locally.

@andrewazores
Copy link
Member Author

Ah, I had outdated dependencies installed locally.

@andrewazores andrewazores marked this pull request as ready for review December 11, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent feat New feature or request safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant