Remove event specifier string text area #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hareetd
previously approved these changes
Jun 16, 2021
andrewazores
force-pushed
the
remove-event-specifier-strings
branch
from
8d34536 to
c4445b4
Compare
|
Rebased to drop the patch reverting #214. No other changes. |
hareetd
previously approved these changes
Jun 17, 2021
andrewazores
force-pushed
the
remove-event-specifier-strings
branch
from
c4445b4 to
f5b9516
Compare
|
Rebased cleanly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cryostatio/cryostat#486
This removes the text area on the Custom Recording creation form, corresponding to the backend change that has removed support for the old event specifier string syntax, which has been superceded by custom templates.
This also enhances the template selection dropdown on the form to organize the templates into TARGET/CUSTOM sections. Previously, all template names were listed together in one group. The indication of TARGET/CUSTOM type was included in the text area when a template was selected.
For testing convenience, this PR includes a commit reverting #214, due to #216. This change is not actually part of this PR. Once this change has been looked over and provisionally approved I will rebase and remove that first commit before merging.