Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(settings): move from vert nav to masthead tool #243

Merged
merged 1 commit into from
Aug 24, 2021
Merged

fix(settings): move from vert nav to masthead tool #243

merged 1 commit into from
Aug 24, 2021

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Aug 19, 2021 •
edited
Loading

Fixes #242

image

image

@andrewazores andrewazores requested review from ebaron and jan-law August 19, 2021 20:10
ebaron
ebaron approved these changes Aug 24, 2021
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended

@andrewazores andrewazores merged commit 0261eea into cryostatio:main Aug 24, 2021
@andrewazores andrewazores deleted the settings-masthead branch August 24, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@jan-law jan-law Awaiting requested review from jan-law

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings page should be accesed via masthead, not vertical nav
2 participants
@andrewazores @ebaron